Fixed Quick Reply "All" Button

[Viper007Bond]

Just a heads up - I fixed the quick reply's "All" button. The person who made the mod kinda f'ed it up.

Technical explanation of what was wrong if you're interested:

The button calls upon this page: http://forum.finalgear.com/quick_reply.php?mode=smilies

The script had something like:

if ($mode = "smilies") {
   blah blah
}

and that only works if variables are set automatically via the URL and that's retarded frankly when that happens. It can cause potential exploitation. Viper007Bond.com has that on and that's why it worked there.

I edited the code so that it has this now:

if ($_GET['mode'] = "smilies") {
  blah blah
}

which is how it shoulda been done in the first place.

 

[Renesis]

The skin I use doesn't have quick reply anyway

 

[Jostyrostelli]

Is it my computer or does the "quote highlighted text" button doesn't work either?

 

[RiCh]

:shock:

Nope my quote highlighted text doesnt work either.
Unless im using it wrong :?

 

[zenon]

The 'Quote Highlighed Text' button is stupid anyway. It doesn't put the person's name you quoted from in the quoted text, so it's really annoying when people use it. I'd rather have it removed than fixed.

 

[Viper007Bond]

Seems to only work in IE. I'll add a note.

 

[Phix]

The skin I use doesn't have quick reply anyway

Whoa, what? There's more skins?!

 

[Renesis]

Yes, look in your profile, there's an option to change them :lol:

 

[Phix]

Yes, look in your profile, there's an option to change them :lol:

What skin are you using? I checked out Charcoal and that was pretty nice but couldn't read the quotes and text was rather hard to read overall. Now I'm trying this Chunk style and I think I've fallen in love with it!

 

[SiR_dude]

Thanks!!!! I was starting to get annoyed by that

 

[Daniel]

Yes, look in your profile, there's an option to change them :lol:

:shock:
Hehe, I did not know that...

 

[Viper007Bond]

A modified version of Charcoal2 is going to be the new default skin once the new version of the site goes up.

I'll probably just replace the logo and change a few colors.

 

[Daniel]

But we can keep this exact default one right?

 

[Viper007Bond]

The skins that are currently available will stay available. I'm just gonna modify the database so that everyone's style choice is Charcoal2, and then you can switch back to whatever one you like again.

Oh, and yes, I'll try and add in the quick reply to Charcoal2.

 

[Daniel]

Who the man!?

 

[Jostyrostelli]

Hire some slaves...sounds like some work...

edit: oops that's what the mods are for i guess..

 

[Daniel]

^They dont do that anymore Josty. Thats why they had that Civil War you know..

 

[Phix]

A modified version of Charcoal2 is going to be the new default skin once the new version of the site goes up.

I'll probably just replace the logo and change a few colors.

No!! Expanded Eos! Or Eos Expanded is a lot better! Just tune it so the user custom titles wrap and fix the width value on the user info box in post!

 

[Viper007Bond]

Charcoal2 kinda matches the new site and I like it. Plus, you can keep using it if you want it.

 

[Overheat]

Well done on the 'All' fix - keep up the good work dude.